[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/zfinx-types.ll:5
+; RUN:    | FileCheck --check-prefix=RV32IF %s
+; RUN: llc -mtriple=riscv32 -mattr=+zfh -target-abi=ilp32f < %s \
+; RUN:    | FileCheck --check-prefix=RV32IF %s
----------------
craig.topper wrote:
> I'm not sure the Zfh or D RUN lines are really doing anything. Especially the Zfh.
> 
> The same bug did happen with double, D extension and RV64 so should probably test that.
I see you added rv64, but didn't add a test case that uses double instead of float.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93298/new/

https://reviews.llvm.org/D93298