[PATCH] D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC

Jim Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 18:52:25 PST 2022


Jim added a comment.

In D120695#3353293 <https://reviews.llvm.org/D120695#3353293>, @craig.topper wrote:

> Creating a new class seems fragile. Does your class call the RISCVPassConfig version of the methods you override? What if your class overrides a method that RISCVPassConfig doesn't override today, but does in the future. Will your class call the newly added override when its done with your override?

Our class would call and reuse the RISCVPassConfig version of the methods in most of situations. 
If upgrade the base upstream, we have to take care every the newly added override function in the parent class if it is already existed in our class.
If the implementations are the same, remove duplicate one from our class. Or trying to reuse the RISCVPassConfig version depending on the need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120695/new/

https://reviews.llvm.org/D120695



More information about the llvm-commits mailing list