[PATCH] D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 18:07:00 PST 2022


craig.topper added a comment.

Creating a new class seems fragile. Does your class call the RISCVPassConfig version of the methods you override? What if your class overrides a method that RISCVPassConfig doesn't override today, but does in the future. Will your class call the newly added override when its done with your override?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120695/new/

https://reviews.llvm.org/D120695



More information about the llvm-commits mailing list