[PATCH] D120455: [CommandLine] Remove `may only occur zero or one times!` error

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 14:26:54 PST 2022


dexonsmith added subscribers: ab, Gerolf, t.p.northover.
dexonsmith added a comment.
Herald added a project: All.



> In D120455#3343539 <https://reviews.llvm.org/D120455#3343539>, @rnk wrote:
>
>> I'm in favor of this change, and the code looks good, but there is some disagreement, so we should get more consensus.
>>
>> @dexonsmith, any thoughts on this change, or is there a better person who can give some perspective on the usability of LLVM options at Apple?
>
> ⬆️

Sorry I missed before!

I don't have a strong opinion; IMO `-mllvm` options shouldn't get used (except by compiler developers) since they're unstable, although I'm sure they get used a little anyway. IMO, if this makes it easier for the intended users (compiler developers) then there isn't a real downside to it.

@ab @t.p.northover @Gerolf , any thoughts from you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120455/new/

https://reviews.llvm.org/D120455



More information about the llvm-commits mailing list