[PATCH] D120455: [CommandLine] Remove `may only occur zero or one times!` error

Mon Feb 28 19:49:00 PST 2022

MaskRay added a comment.

In D120455#3343588 <https://reviews.llvm.org/D120455#3343588>, @rnk wrote:

> I'm not familiar with gcc `--param`, but if this is it <https://chromium.googlesource.com/chromiumos/third_party/gcc/+/refs/heads/firmware-bolt_kirby-4979.B/gcc/params.def>, then it doesn't seem so bad. Nobody is suggesting that this be a stable, supported interface where we make long term commitments for LLVM option stability.
>
> In any case, `-mllvm` already exists, and cl::opt is used by other components (MLIR). This change by itself is reasonable, and it doesn't stop us from working to reduce the exposed support surface of clang in the future. Having a slightly bad user experience for mllvm options doesn't actually reduce the support surface area of clang. We may have to agree to disagree here. :)

@echristo What do you think of my updated summary?

In D120455#3343539 <https://reviews.llvm.org/D120455#3343539>, @rnk wrote:

> I'm in favor of this change, and the code looks good, but there is some disagreement, so we should get more consensus.
>
> @dexonsmith, any thoughts on this change, or is there a better person who can give some perspective on the usability of LLVM options at Apple?

🙄

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120455/new/

https://reviews.llvm.org/D120455