[PATCH] D120623: [lit] Read command stdout/stderr as text on Windows

Tue Mar 1 13:23:24 PST 2022

rnk added a comment.

In D120623#3352640 <https://reviews.llvm.org/D120623#3352640>, @mstorsjo wrote:

> @rnk What do you think about the test in https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/tests/Inputs/shtest-shell/stdout-encoding.txt which gets broken by this patch? It was added in https://github.com/llvm/llvm-project/commit/27fdf8a29d1e0740c342d428fa48eda7b088ac8e / D69207 <https://reviews.llvm.org/D69207>. Should we just conclude that we shouldn't print non-ascii to stdout in lit tests and remove that testcase?

What is the failure mode? Does lit behave reasonably when binary output is printed to stdout, or does it through an exception? We should expect developers to do this by accident from time to time, and we should adjust that test to express what we want from lit. I guess I'm saying we should keep the test and update the expectations in the outer test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120623/new/

https://reviews.llvm.org/D120623