[PATCH] D120623: [lit] Read command stdout/stderr as text on Windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.
Herald added a project: All.

@rnk What do you think about the test in https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/tests/Inputs/shtest-shell/stdout-encoding.txt which gets broken by this patch? It was added in https://github.com/llvm/llvm-project/commit/27fdf8a29d1e0740c342d428fa48eda7b088ac8e / D69207 <https://reviews.llvm.org/D69207>. Should we just conclude that we shouldn't print non-ascii to stdout in lit tests and remove that testcase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120623/new/

https://reviews.llvm.org/D120623