[PATCH] D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 1 07:38:42 PST 2022
jrtc27 added a comment.
Inheriting from the pass doesn't make sense, just change the implementations. The TargetPassConfig has access to the TM for a reason. As someone with significant downstream changes I am sympathetic to changing upstream code to be more accommodating, but this change just seems motivated by an arbitrary downstream decision that goes against the intent of LLVM's structure just to avoid the occasional merge conflict (RISCVPassConfig hardly changes much).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120695/new/
https://reviews.llvm.org/D120695
More information about the llvm-commits
mailing list