[PATCH] D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC

Jim Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 28 23:21:18 PST 2022


Jim added a comment.

In D120695#3350392 <https://reviews.llvm.org/D120695#3350392>, @craig.topper wrote:

> Isn’t the function that returns the class in this cpp file? Why are you able to change that function in your downstream but can’t add your new class to the cpp in your downstream?

The return function in this cpp is the only place needed to be changed to return new class. 
Also add a new #include to include new class header file in this cpp.

In my mind, this two places are hard to conflict with upstream or easily to fix the conflict if upgrade our downstream.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120695/new/

https://reviews.llvm.org/D120695



More information about the llvm-commits mailing list