[PATCH] D120687: [llvm-nm][NFC] remove global variable " std::vector<NMSymbol> SymbolList"

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added a comment.

In D120687#3350476 <https://reviews.llvm.org/D120687#3350476>, @jhenderson wrote:

> I think you may be doing too much in this patch. I think you should start with a patch that literally just changes from a global SymbolList to a local one that's passed down the stack as required. You can then make other changes on top of that to continue the refactoring we discussed.



  Any criterion on how to create a NFC patch?  It is difficult for me the control the size of the NFC patch, I already did three refactor patches on the llvm-nm.cpp before I can reach your comment on the patch https://reviews.llvm.org/D112735 , I always feel sad when you tell me that I need to split a patches into two patches , it is time consume  for me to split the patches after I post a patch.  I need to  compile and test the separate patch.  And I also have my team work on my hand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120687/new/

https://reviews.llvm.org/D120687