[PATCH] D120687: [llvm-nm][NFC] remove global variable " std::vector<NMSymbol> SymbolList"

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 00:05:39 PST 2022


jhenderson added a comment.

I think you may be doing too much in this patch. I think you should start with a patch that literally just changes from a global SymbolList to a local one that's passed down the stack as required. You can then make other changes on top of that to continue the refactoring we discussed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120687/new/

https://reviews.llvm.org/D120687



More information about the llvm-commits mailing list