[PATCH] D120585: make TargetMachine visible from TargetTransformInfo

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D120585#3349367 <https://reviews.llvm.org/D120585#3349367>, @vtjnash wrote:

> It can matter in what ways the the "target-attribute" is different. Just grepping the source tree reveals there are several existing IR passes that depend on examining this function attribute, and are already altering their behavior based on the value. For example, it appears that the msan pass should be falling back to examining the TTI's notion of the target machine to locate the function arguments correctly, if I am reading the source comments here correctly:
>
> https://github.com/llvm/llvm-project/blob/d56ef5ed20c5c1380c2d97e970c8fc4d4166bdb8/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp#L4220-L4232

When you say msan should be "falling back", do you mean when the "target-attribute" isn't present?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120585/new/

https://reviews.llvm.org/D120585