[PATCH] D120585: make TargetMachine visible from TargetTransformInfo

Jameson Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 28 11:07:06 PST 2022


vtjnash added a comment.

It can matter in what ways the the "target-attribute" is different. Just grepping the source tree reveals there are several existing IR passes that depend on examining this function attribute, and are already altering their behavior based on the value. For example, it appears that the msan pass should be falling back to examining the TTI's notion of the target machine to locate the function arguments correctly, if I am reading the source comments here correctly:

https://github.com/llvm/llvm-project/blob/d56ef5ed20c5c1380c2d97e970c8fc4d4166bdb8/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp#L4220-L4232


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120585/new/

https://reviews.llvm.org/D120585



More information about the llvm-commits mailing list