[PATCH] D120645: [Object] Skip section offset checking for /<XFGHASHMAP>/

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 28 01:07:01 PST 2022


mstorsjo added a reviewer: rnk.
mstorsjo added a comment.

Can you add a testcase, e.g. somewhere in `llvm/test/tools/llvm-ar` or similar?



================
Comment at: llvm/lib/Object/Archive.cpp:166
   // Don't include the EndCond if there is one.
-  return StringRef(ArMemHdr->Name, end);
+  return StringRef(ArMemHdr->Name, End);
 }
----------------
This change seems unrelated to the rest. Even if some cleanliness tool might complain about deviations from the coding convention, we normally don't change much outside of what the patch itself covers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120645/new/

https://reviews.llvm.org/D120645



More information about the llvm-commits mailing list