[PATCH] D120645: [Object] Skip section offset checking for /<XFGHASHMAP>/

[Tobias Hieta via Phabricator via llvm-commits]

thieta requested changes to this revision.
thieta added a comment.
This revision now requires changes to proceed.

Thanks for doing this. I think it looks sane over all, but I would like to see:

- Better comment about the symbol
- A test that cover this symbol and that we skip it and not bomb out, like we currently do.



================
Comment at: llvm/lib/Object/Archive.cpp:259
       return Name;
+    if (Name.equals("/<XFGHASHMAP>/")) // names in Windows SDK for Windows 11
+      return Name;
----------------
I think this comment could be more descriptive. We should say what this symbol is for and that we just skip it for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120645/new/

https://reviews.llvm.org/D120645