[PATCH] D119010: [AggressiveInstCombine] Recognize table-based ctz implementation and enable it for AARCH64 at -O3

Mon Feb 28 00:15:08 PST 2022

gsocshubham added a comment.

In D119010#3297623 <https://reviews.llvm.org/D119010#3297623>, @djtodoro wrote:

> Thanks for this.
>
> This should be implemented as a patch on top of the https://reviews.llvm.org/D113291 (as a child of the D113291 <https://reviews.llvm.org/D113291>).

Hello @djtodoro

How can I submit my patch based on https://reviews.llvm.org/D113291 ?
While submitting current patch, I could not find a option to make my patch as child patch of yours.

Can you please point to the process of doing it?

================
Comment at: llvm/test/Transforms/AggressiveInstCombine/AArch64/lower-table-based-ctz.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -aggressive-instcombine -mtriple aarch64-linux-gnu -S < %s | FileCheck %s
----------------
craig.topper wrote:
> Why are there less tests than the other patch?
This should go once review on this patch - https://reviews.llvm.org/D120462 is ready.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119010/new/

https://reviews.llvm.org/D119010