[PATCH] D120545: [LoongArch] Add EncoderMethod to unusual' immediate operand

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 27 07:27:19 PST 2022


xen0n added a comment.

Maybe something like "transformed operands" is better than "unusual", for the changeset title? The code looks good though, only one minor nit.



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp:64-65
+  /// Return binary encoding of an immediate operand specified by OpNo.
+  /// The value returned is the value of the immediate arithmetical right
+  //  shifts 2.
+  /// Note that this function is dedicated to specific immediate types,
----------------
  /// The value returned is the value of the immediate shifted right
  /// arithmetically by 2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120545/new/

https://reviews.llvm.org/D120545



More information about the llvm-commits mailing list