[PATCH] D120545: [LoongArch] Add EncoderMethod to unusual' immediate operand

Lu Weining via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 26 01:15:49 PST 2022


SixWeining added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp:55
+
+  unsigned getImmOpValueSub1(const MCInst &MI, unsigned OpNo,
+                             SmallVectorImpl<MCFixup> &Fixups,
----------------
myhsu wrote:
> are these two functions dedicated to the `unusual` immediate you mentioned in another patch? If so, can you add some description comments here?
Yes, they are dedicated to those `unusual` immediates. I just add some descriptions which I think may improve code readability. Many thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120545/new/

https://reviews.llvm.org/D120545



More information about the llvm-commits mailing list