[PATCH] D98230: [LSR] Add reconciliation of unfoldable offsets

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:696
+  /// without unfoldable offsets.
+  bool LSRUnfOffsetsReconc() const;
+
----------------
greened wrote:
> This name could be more descriptive, like `LSRShouldGroupUnfoldableOffsets` or `LSRShouldReconcileUnfoldableOffsets`, though "reconcile" is kind of generic and I don't really have a better term.  Even "unfoldable" isn't clear unless you're deep into LSR.  Is there some name that people developing targets would look at and have some idea of what their target should return, without being an LSR expert?
Yeah, that's a better name :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98230/new/

https://reviews.llvm.org/D98230