[PATCH] D113725: Validate chained fixup image formats

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 11:40:33 PST 2022


aprantl added inline comments.


================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:4833-4836
+  std::vector<ChainedFixupTarget> Targets;
+  if (!(*CFHeaderOrErr))
+    return Targets;
   return Targets;
----------------
keith wrote:
> Is this returning Targets in both cases intentional? Maybe it's a placeholder for more upcoming logic?
It's a placeholder.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113725/new/

https://reviews.llvm.org/D113725



More information about the llvm-commits mailing list