[PATCH] D113725: Validate chained fixup image formats

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 22 10:58:17 PST 2022


keith accepted this revision.
keith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:4833-4836
+  std::vector<ChainedFixupTarget> Targets;
+  if (!(*CFHeaderOrErr))
+    return Targets;
   return Targets;
----------------
Is this returning Targets in both cases intentional? Maybe it's a placeholder for more upcoming logic?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113725/new/

https://reviews.llvm.org/D113725



More information about the llvm-commits mailing list