[PATCH] D120438: [SLP][NFC] Test for a follow-up fix of the the vector min/max instrinsic cost calculation.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 13:35:44 PST 2022


fhahn added a comment.

> t. But I think that arith-smax.ll is already quite a large test with four check-prefixes, so we should probably avoid making it even larger? I could rename this test to arith-smax-cost.ll and add the unsigned case? What do you think?

Yeah sounds not worth extending the existing test if it requires more surgery to the check lines. Renaming the file to be in line with the existing tests should be fine. Maybe ` arith-max-cost.ll ` so the unsigned test can also be included?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120438/new/

https://reviews.llvm.org/D120438



More information about the llvm-commits mailing list