[PATCH] D120438: [SLP][NFC] Test for a follow-up fix of the the vector min/max instrinsic cost calculation.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 12:09:16 PST 2022


vporpo added a comment.

Good point. I tried adding this function to arith-smax.ll but the issue is that the test maps multiple RUN lines to the same check-prefix and for this particular function that I am adding the output is actually different. I could fix this by adding a few more check-prefixes in arith-small.ll to avoid this conflict. But I think that arith-smax.ll is already quite a large test with four check-prefixes, so we should probably avoid making it even larger? I could rename this test to arith-smax-cost.ll and add the unsigned case? What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120438/new/

https://reviews.llvm.org/D120438



More information about the llvm-commits mailing list