[llvm] 1e396af - [Symbolizer] Move ctor/dtor into .cpp file
Benjamin Kramer via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 24 05:20:50 PST 2022
Author: Benjamin Kramer
Date: 2022-02-24T14:20:15+01:00
New Revision: 1e396affca6a0d21247d960c93a415e8f6fe0301
URL: https://github.com/llvm/llvm-project/commit/1e396affca6a0d21247d960c93a415e8f6fe0301
DIFF: https://github.com/llvm/llvm-project/commit/1e396affca6a0d21247d960c93a415e8f6fe0301.diff
LOG: [Symbolizer] Move ctor/dtor into .cpp file
On some standard library configurations these have a dependency on the
complete type of SymbolizableModule. They also do a lot of
copying/freeing so no point in inlining them.
Added:
Modified:
llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h b/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
index b1833d56db722..552f2d315c50b 100644
--- a/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
+++ b/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
@@ -61,9 +61,9 @@ class LLVMSymbolizer {
};
LLVMSymbolizer() = default;
- LLVMSymbolizer(const Options &Opts) : Opts(Opts) {}
+ LLVMSymbolizer(const Options &Opts);
- ~LLVMSymbolizer() { flush(); }
+ ~LLVMSymbolizer();
// Overloads accepting ObjectFile does not support COFF currently
Expected<DILineInfo> symbolizeCode(const ObjectFile &Obj,
diff --git a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
index 1a163d98e8402..dac96c084b276 100644
--- a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
+++ b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
@@ -39,6 +39,10 @@
namespace llvm {
namespace symbolize {
+LLVMSymbolizer::LLVMSymbolizer(const Options &Opts) : Opts(Opts) {}
+
+LLVMSymbolizer::~LLVMSymbolizer() = default;
+
template <typename T>
Expected<DILineInfo>
LLVMSymbolizer::symbolizeCodeCommon(const T &ModuleSpecifier,
More information about the llvm-commits
mailing list