[PATCH] D118777: [flang] Add runtime support for GET_COMMAND

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 05:08:48 PST 2022


rovka updated this revision to Diff 411088.
rovka edited the summary of this revision.
rovka added a comment.

I finally got around to updating this to write the length to an int descriptor.
Also:
Added the source & line parameters so we can have RUNTIME_CHECKS.
Added a test fixture with a completely empty argv.

I'm going to update the other intrinsics in the file to the same model (i.e. single entry point with int descriptors, RUNTIME_CHECKs for invalid descriptors, support for empty argv), and with that I can probably remove some redundant checks from some of the helpers. That's going to be a different patch though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118777/new/

https://reviews.llvm.org/D118777

Files:
  flang/include/flang/Runtime/command.h
  flang/runtime/command.cpp
  flang/unittests/Runtime/CommandTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118777.411088.patch
Type: text/x-patch
Size: 16196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220224/495275df/attachment.bin>


More information about the llvm-commits mailing list