[PATCH] D120287: [RISCV] Add isel patterns for masked RISCVISD::FMA_VL with RISCVISD::FNEG_VL.

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.

I understand `srcval` here is

  /// SRCVALUE - This is a node type that holds a Value* that is used to
  /// make reference to a value in the LLVM IR.                         
  SRCVALUE,                                                             

It seems a bit hacky at first and I guess it works because those patterns are kind of skipped during matching, right?

> If we don't think srcvalue is ok, we'll need to change to true_mask or use C++ code to match.

Does it make sense to have `riscv_fmsub_vl`, `riscv_fnmsub_vl`, ... nodes that we combine earlier using `riscv_fma_vl` and others? I understand this would make the patterns straightforward but maybe it is not feasible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120287/new/

https://reviews.llvm.org/D120287