[PATCH] D107955: [ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro marked an inline comment as done.
ro added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/retain-section.yaml:46
+
+# SOLARIS-GNU-ERR: error: unknown bit value
+
----------------
jhenderson wrote:
> It would be worth including the context saying which flag is the unknown value.
Good point indeed.  I've indented the `Flags:` part, matching what `yaml2obj` does.  Is this ok or is the output supposed to be aligned in the testcase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107955/new/

https://reviews.llvm.org/D107955