[PATCH] D107955: [ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on Solaris

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/retain-section.yaml:46
+
+# SOLARIS-GNU-ERR: error: unknown bit value
+
----------------
It would be worth including the context saying which flag is the unknown value.


================
Comment at: llvm/test/tools/yaml2obj/ELF/retain-section.yaml:62
+
+# GNU-SOLARIS-ERR:error: unknown bit value
+
----------------
Ditto. Also add a space to match the earlier veresion.


================
Comment at: llvm/test/tools/yaml2obj/ELF/retain-section.yaml:73
+    Flags: [ SHF_SUNW_NODISCARD ]
+
----------------
Nit: too many new lines at EOF (need exactly one).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107955/new/

https://reviews.llvm.org/D107955