[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm marked 3 inline comments as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/tls-loads-control3.ll:40-42
+; HOIST0-NEXT:    data16
+; HOIST0-NEXT:    data16
+; HOIST0-NEXT:    rex64
----------------
pengfei wrote:
> `data16` and `rex64` don't seem correct instructions.
Yes, there are prefix not real instruction, I can see them in X86AsmParser.cpp , not clear what they are used for ? Seems no relation with this patch.


================
Comment at: llvm/test/CodeGen/X86/tls-loads-control3.ll:160
+; HOIST0-NEXT:    pushq %r15
+; HOIST0-NEXT:    .cfi_def_cfa_offset 16
+; HOIST0-NEXT:    pushq %r14
----------------
pengfei wrote:
> xiangzhangllvm wrote:
> > pengfei wrote:
> > > Add `nounwind` in attributes to avoid cfi directives.
> > Add nounwind to #0, but seems cfi still here, anyway, that is not important, I think.
> Did you re-generate the tests? It should work. lit test will fail if you didn't update the tests.
Yes, re-generate it with update_llc_test_checks.py
let me show my local status:

```
[xiangzh1 at ..]$./llvm/utils/update_llc_test_checks.py llvm/test/CodeGen/X86/tls-loads-control3.ll
[xiangzh1 at ..]$git diff
[xiangzh1 at ..]$llvm-lit llvm/test/CodeGen/X86/tls-loads-control3.ll
-- Testing: 1 tests, 1 workers --
PASS: LLVM :: CodeGen/X86/tls-loads-control3.ll (1 of 1)

Testing Time: 0.21s
  Passed: 1
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000