[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/tls-loads-control3.ll:40-42
+; HOIST0-NEXT:    data16
+; HOIST0-NEXT:    data16
+; HOIST0-NEXT:    rex64
----------------
`data16` and `rex64` don't seem correct instructions.


================
Comment at: llvm/test/CodeGen/X86/tls-loads-control3.ll:160
+; HOIST0-NEXT:    pushq %r15
+; HOIST0-NEXT:    .cfi_def_cfa_offset 16
+; HOIST0-NEXT:    pushq %r14
----------------
xiangzhangllvm wrote:
> pengfei wrote:
> > Add `nounwind` in attributes to avoid cfi directives.
> Add nounwind to #0, but seems cfi still here, anyway, that is not important, I think.
Did you re-generate the tests? It should work. lit test will fail if you didn't update the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000