[PATCH] D119233: [sancov][sanitizer-common] Correct sanitizer coverage point
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 22 15:13:20 PST 2022
MaskRay added a comment.
See D120362 <https://reviews.llvm.org/D120362>: I think we should refactor the -1/-4 thing first.
This patch should focus on fixing the offset for `__sanitizer_cov_trace_pc_guard`.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp:227
+ __sancov::pc_guard_controller.TracePcGuard(
+ guard, StackTrace::GetPreviousInstructionPc(GET_CALLER_PC()));
}
----------------
I have confirmed that aarch64 needs this as well.
================
Comment at: llvm/include/llvm/ADT/Triple.h:821
+ /// Tests whether the target is Sparc.
+ bool isSparc() const {
+ return getArch() == Triple::sparc || getArch() == Triple::sparcv9 ||
----------------
Upload a separate patch for the Triple.h change. You may add `ro` as a reviewer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119233/new/
https://reviews.llvm.org/D119233
More information about the llvm-commits
mailing list