[PATCH] D119233: [sancov][sanitizer-common] Correct sanitizer coverage point

[Xiaodong Liu via Phabricator via llvm-commits]

XiaodongLoong added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp:17-18
 #include "sanitizer_common.h"
-#include "sanitizer_file.h"
+#  include "sanitizer_common/sanitizer_stacktrace.h"
+#  include "sanitizer_file.h"
 
----------------
XiaodongLoong wrote:
> clang-format might make a mistake as following:
> 
>     clang-format suggested style edits found:
> 
>               14 #include "sanitizer_allocator_internal.h"
>               15 #include "sanitizer_atomic.h"
>               16 #include "sanitizer_common.h"
>     >>> -     17 #include "sanitizer_common/sanitizer_stacktrace.h"
>         -     18 #include "sanitizer_file.h"
>         +        #  include "sanitizer_common/sanitizer_stacktrace.h"
>         +        #  include "sanitizer_file.h"
>               19 
>               20 using namespace __sanitizer;
>               21 
>               22 using AddressRange = LoadedModule::AddressRange;
> 
> 
> What should I do for this issue?
After rebased code, it is OK now.

It seems that the building failure is not caused by this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119233/new/

https://reviews.llvm.org/D119233