[PATCH] D120265: AMDGPU: Use the implicit kernargs for code object version 5

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h:326-328
+    PRIVATE_BASE,
+    SHARED_BASE,
+    QUEUE_PTR,
----------------
arsenm wrote:
> You shouldn't merge these into the same enum. This enum should be renamed, this is for a different clover ABI
I am not clear what is the clover ABI. But GRID_DIM and GRID_OFFSET have never been used. Can we simply remove them? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120265/new/

https://reviews.llvm.org/D120265