[PATCH] D120265: AMDGPU: Use the implicit kernargs for code object version 5

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:410-412
+      // We are going to use the implicit kernarg for V5.
+      if (AMDGPU::getAmdhsaCodeObjectVersion() == 5)
+        removeAssumedBits(IMPLICIT_ARG_PTR);
----------------
arsenm wrote:
> This isn't covered by any test changes
Are the tests of @llvm_amdgcn_is_private, @llvm_amdgcn_is_shared and @addrspacecast under v5 covering this?  For example, for @llvm_amdgcn_is_shared,  "s_load_dword s0, s[6:7], 0xcc" is generated to load 
the shared_base and s[6:7] holds the argument ptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120265/new/

https://reviews.llvm.org/D120265