[PATCH] D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added inline comments.


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:320
+                    << "\n";);
+  auto Loc = Binaries.find(buildIDToString(ID));
+  if (Loc != Binaries.end()) {
----------------
fche2 wrote:
> Don't you need a mutex-guard on this operation?
Thanks so much for catching this!
I propose to switch to [[ https://llvm.org/doxygen/RWMutex_8h_source.html | RW-Mutex ]] so the readers can read without blocking each other.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114845/new/

https://reviews.llvm.org/D114845