[PATCH] D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo.

[Frank Ch. Eigler via Phabricator via llvm-commits]

fche2 added inline comments.


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:320
+                    << "\n";);
+  auto Loc = Binaries.find(buildIDToString(ID));
+  if (Loc != Binaries.end()) {
----------------
Don't you need a mutex-guard on this operation?


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:335
+                    << "\n";);
+  auto Loc = DebugBinaries.find(buildIDToString(ID));
+  if (Loc != DebugBinaries.end()) {
----------------
Ditto re. mutex-guard?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114845/new/

https://reviews.llvm.org/D114845