[PATCH] D120318: [MC][ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on Solaris

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 22 12:59:03 PST 2022


ro marked an inline comment as done.
ro added inline comments.


================
Comment at: llvm/lib/MC/MCSectionELF.cpp:108
 
+  // If there are os-specific flags, print them.
+  if (T.isOSSolaris())
----------------
MaskRay wrote:
> Maybe conciser: `// Print OS-specific flags.``
I'd rather keep if for consistency with the next comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120318/new/

https://reviews.llvm.org/D120318



More information about the llvm-commits mailing list