[PATCH] D120318: [MC][ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on Solaris

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/MC/MCSectionELF.cpp:108
 
+  // If there are os-specific flags, print them.
+  if (T.isOSSolaris())
----------------
Maybe conciser: `// Print OS-specific flags.``


================
Comment at: llvm/test/CodeGen/X86/elf-retain.ll:6
 ; RUN: llc -mtriple=x86_64 -no-integrated-as -binutils-version=2.35 < %s | FileCheck %s --check-prefix=OLDGAS
+; Solaris uses the equivalent SHF_SUNW_NODISCARD flag, also represented as "R".
+; RUN: llc -mtriple=x86_64-solaris < %s | FileCheck %s
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120318/new/

https://reviews.llvm.org/D120318