[PATCH] D119821: [Bitcode] Store type IDs for values

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/ValueList.cpp:125
+  if (Value *V = ValuePtrs[Idx].first) {
     // If the types don't match, it's invalid.
     if (Ty && Ty != V->getType())
----------------
aeubanks wrote:
> should this also check `TyID`?
I'm not entirely sure here, but I think not, as multiple type IDs may encode the same type, and these would be technically compatible.

I'll check this again once the full propagation is implemented, as we can currently get a dummy ID here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119821/new/

https://reviews.llvm.org/D119821