[PATCH] D119821: [Bitcode] Store type IDs for values

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Bitcode/Reader/ValueList.cpp:125
+  if (Value *V = ValuePtrs[Idx].first) {
     // If the types don't match, it's invalid.
     if (Ty && Ty != V->getType())
----------------
should this also check `TyID`?


================
Comment at: llvm/lib/Bitcode/Reader/ValueList.h:29
 class BitcodeReaderValueList {
-  std::vector<WeakTrackingVH> ValuePtrs;
+  std::vector<std::pair<WeakTrackingVH, unsigned>> ValuePtrs;
 
----------------
could you add a comment about what the unsigned represents?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119821/new/

https://reviews.llvm.org/D119821