[PATCH] D119917: [Support] Add CSKY target parser and attributes parser

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added inline comments.


================
Comment at: llvm/lib/Support/CSKYAttributeParser.cpp:147
+  return Error::success();
+}
----------------
zixuan-wu wrote:
> DavidSpickett wrote:
> > I assume that here there's no need for "None" or "Error" because you'd only be reading the hard FP mode if you already got hardfp from fpuABI.
> Sorry. I don't know what exactly you mean.  Make fpuHardFP return other type instead of Error?
I wondered if you needed a way to signal that the hard FP modes were unrecognised or none were enabled.

Likely you're going to check this later though so different code will handle that situation. When you are checking that 2 objects are compatible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119917/new/

https://reviews.llvm.org/D119917