[PATCH] D119917: [Support] Add CSKY target parser and attributes parser

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added a comment.

Yes, it's better to dedupe code in follow-up patches.



================
Comment at: llvm/lib/Support/CSKYAttributeParser.cpp:147
+  return Error::success();
+}
----------------
DavidSpickett wrote:
> I assume that here there's no need for "None" or "Error" because you'd only be reading the hard FP mode if you already got hardfp from fpuABI.
Sorry. I don't know what exactly you mean.  Make fpuHardFP return other type instead of Error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119917/new/

https://reviews.llvm.org/D119917