[PATCH] D118766: [CodeGen] Use the non-pointer LLT equivalent to check regclass type

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 18:01:05 PST 2022


arsenm added a comment.

In D118766#3322284 <https://reviews.llvm.org/D118766#3322284>, @lewis-revill wrote:

> In D118766#3308106 <https://reviews.llvm.org/D118766#3308106>, @arsenm wrote:
>
>> Can you add a verifier test for this?
>>
>> The bridging between LLT and MVT is increasingly painful, we should probably start putting in the effort to move more infrastructure to directly using LLT
>
> Sorry not quite sure what exactly a verifier test refers to. Do you mean an LLC test for the issue in RISC-V that exposed this or something else?

Yes. You can write a test that fails the verifier and check the verifier output is consistent here. e.g. I added such a test in cea97fc0fcd86d52f9efa215116356b72faeb17d <https://reviews.llvm.org/rGcea97fc0fcd86d52f9efa215116356b72faeb17d> when I added this version


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118766/new/

https://reviews.llvm.org/D118766



More information about the llvm-commits mailing list