[PATCH] D120094: [CallingConv] Generate isArgumentRegister() predicate via tablegen

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 15:05:15 PST 2022


void added a comment.

In D120094#3331146 <https://reviews.llvm.org/D120094#3331146>, @jrtc27 wrote:

> Revision summary seems to be totally lacking any explanation of what this actually is for. Also how is this meant to interact with architectures like MIPS where return value registers aren't argument registers (v0 and v1); is it meant to include those or not? The name suggests it does, but the old function name suggested it didn't (and was just a stub outside of X86?).

I improved the commit message.

You're correct that we don't care about return values here. I changed the predicate's name to better reflect that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120094/new/

https://reviews.llvm.org/D120094



More information about the llvm-commits mailing list