[PATCH] D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept)

[Samuel Bronson via Phabricator via llvm-commits]

SamB added a comment.
Herald added subscribers: alextsao1999, luke957.

So, um, I would like to look at your patches, but I'm not having much success running "arc patch" against them.

For example, trying to apply this one results in something that starts like this:

   ARGV  '/usr/share/arcanist/bin/../scripts/arcanist.php' 'patch' '--trace' 'D99750'
   LOAD  Loaded "phutil" from "/usr/share/libphutil/src".
   LOAD  Loaded "arcanist" from "/usr/share/arcanist/src".
  Config: Reading user configuration file "/home/naesten/.arcrc"...
  Config: Did not find system configuration at "/etc/arcconfig".
  Working Copy: Reading .arcconfig from "/home/naesten/llvm-project/.arcconfig".
  Working Copy: Path "/home/naesten/llvm-project" is part of `git` working copy "/home/naesten/llvm-project".
  Working Copy: Project root is at "/home/naesten/llvm-project".
  Config: Did not find local configuration at "/home/naesten/llvm-project/.git/arc/config".
  >>> [0] (+0) <http> https://reviews.llvm.org/api/differential.querydiffs
  <<< [0] (+130) <http> 130,791 us
  >>> [1] (+130) <http> https://reviews.llvm.org/api/user.whoami
  <<< [1] (+191) <http> 60,373 us
  >>> [2] (+191) <http> https://reviews.llvm.org/api/differential.querydiffs
  <<< [2] (+775) <http> 584,009 us
  >>> [3] (+801) <http> https://reviews.llvm.org/api/repository.query
  <<< [3] (+869) <http> 68,718 us
  >>> [4] (+870) <exec> $ git --version
  <<< [4] (+872) <exec> 1,854 us
  >>> [5] (+872) <exec> $ git status --porcelain=2 -z
  <<< [5] (+1,016) <exec> 143,931 us
  >>> [6] (+1,016) <exec> $ git show -s --format='%H' '' --
  <<< [6] (+1,018) <exec> 1,804 us
   INFO  Base commit is not in local repository; trying to fetch.
  >>> [7] (+1,018) <exec> $ git fetch --quiet --all
  <<< [7] (+1,288) <exec> 269,787 us
  >>> [8] (+1,288) <exec> $ git show -s --format='%H' '' --
  <<< [8] (+1,290) <exec> 1,654 us
  >>> [9] (+1,290) <exec> $ git symbolic-ref --quiet HEAD
  <<< [9] (+1,291) <exec> 1,428 us
  >>> [10] (+1,292) <exec> $ git rev-parse --verify 'arcpatch-D99750'
  <<< [10] (+1,293) <exec> 1,565 us
  Branch name arcpatch-D99750 already exists; trying a new name.

I trimmed the rest, but since it didn't really find a base commit -- and it kinda looks like it was looking for one called `''` -- it shouldn't be particularly surprising that the patch failed to apply.

So, um, yeah. Do you have one or more git branches I could play with instead, or perhaps you could somehow communicate the proper context to Differential?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99750/new/

https://reviews.llvm.org/D99750