[PATCH] D117580: [LoopVectorize] Support conditional in-loop vector reductions
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 21 08:43:19 PST 2022
david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the changes. :)
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8597
+ unsigned NumIncoming = Phi->getNumIncomingValues();
+ // For in-loop reductions, we do not need to create an additional select.
+ VPValue *InLoopVal = nullptr;
----------------
I think this is ok for now because we don't support chained reductions. If at some point we do want to support them, then we may have to do more work to look through the chain.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117580/new/
https://reviews.llvm.org/D117580
More information about the llvm-commits
mailing list