[PATCH] D117580: [LoopVectorize] Support conditional in-loop vector reductions
Kerry McLaughlin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 21 08:13:13 PST 2022
kmclaughlin added inline comments.
================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:1129
- // Check that the Phi has one (or two for min/max) uses.
- if (!Phi->hasNUses(ExpectedUses))
+ // Check that the Phi has one (or two for min/max or conditional) uses.
+ if (!Phi->hasNUses(ExpectedUses + ExtraPhiUses))
----------------
david-arm wrote:
> nit: I think for conditional min/max reductions there would be three uses. Perhaps you can reword as something like:
>
> // Check that the Phi has one (or two for min/max) uses for unconditional reductions, plus
> // an extra use for conditional reductions.
>
> What do you think?
I think that's more accurate, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117580/new/
https://reviews.llvm.org/D117580
More information about the llvm-commits
mailing list