[PATCH] D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 15:57:40 PST 2022


aheejin added a comment.

Yes, all three also fail with LLVM ToT.

`core2.test_source_map` and `core2.test_source_map_minimal_runtime` crashes with:

  /usr/local/google/home/aheejin/emscripten/tests/sourcemap2json.js:15
  new SourceMapConsumer(fs.readFileSync(process.argv[2], 'utf-8')).then((consumer) => {
                                                                   ^
  
  TypeError: (intermediate value).then is not a function
      at Object.<anonymous> (/usr/local/google/home/aheejin/emscripten/tests/sourcemap2json.js:15:66)
      at Module._compile (node:internal/modules/cjs/loader:1097:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
      at Module.load (node:internal/modules/cjs/loader:975:32)
      at Function.Module._load (node:internal/modules/cjs/loader:822:12)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
      at node:internal/main/run_main_module:17:47
  Thrown at:
      at /usr/local/google/home/aheejin/emscripten/tests/sourcemap2json.js:15:66
      at Module._compile (node:internal/modules/cjs/loader:1097:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
      at Module.load (node:internal/modules/cjs/loader:975:32)
      at Module._load (node:internal/modules/cjs/loader:822:12)
      at executeUserEntryPoint (node:internal/modules/run_main:77:12)
      at node:internal/main/run_main_module:17:47
  
  Node.js v17.5.0
  -- end program output --
  FAIL

In case of `other.test_system_include_paths`, the output is different:

  --- expected
  +++ actual
  @@ -1 +1 @@
  -/usr/local/google/home/aheejin/emscripten/system
  +/usr/local/google/home/aheejin/local/include

In case you have a clue off the top of your head I'd appreciate that. I'll land this then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120013/new/

https://reviews.llvm.org/D120013



More information about the llvm-commits mailing list