[PATCH] D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local

Thu Feb 17 14:31:31 PST 2022

sbc100 accepted this revision.
sbc100 added a comment.

In D120013#3330881 <https://reviews.llvm.org/D120013#3330881>, @aheejin wrote:

> In D120013#3329550 <https://reviews.llvm.org/D120013#3329550>, @sbc100 wrote:
>
>> Can you verify that the `core2` and `other` emscripten test suites both pass with this change
>
> `test_source_map` and `test_source_map_minimal_runtime` failed in `core2`, and `test_system_include_paths` failed in `other`, but looking at the errors they don't seem to be related to this. Why they error I'm not sure; maybe because of my local machine settings or something. Others all ran OK.

As long as you verify that those test also fail with llvm ToT then that could be fine.   We might want to figure out what is going on with your setup but that sounds like a different issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120013/new/

https://reviews.llvm.org/D120013