[PATCH] D120049: [DAG-ISEL]remove unnecessary getNode() for SDValue type. NFC
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 17 08:37:36 PST 2022
craig.topper added a comment.
This seems fine to me.
All of the calls to dump() can probably use `.` instead of `->`
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19712
- uint64_t ShiftAmt = In.getNode()->getConstantOperandVal(1);
+ uint64_t ShiftAmt = In->getConstantOperandVal(1);
----------------
This one can be `In.getConstantOperandVal(1)` since we have a forwarding method for that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120049/new/
https://reviews.llvm.org/D120049
More information about the llvm-commits
mailing list